Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbbFDHWI (ORCPT ); Thu, 4 Jun 2015 03:22:08 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:35442 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbFDHV6 (ORCPT ); Thu, 4 Jun 2015 03:21:58 -0400 Date: Thu, 4 Jun 2015 09:21:53 +0200 From: Ingo Molnar To: "Wangnan (F)" Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Adrian Hunter , Alexei Starovoitov , Brendan Gregg , Daniel Borkmann , David Ahern , He Kuang , Jiri Olsa , Kaixu Xia , Madhavan Srinivasan , Masami Hiramatsu , Michael Ellerman , Namhyung Kim , Peter Zijlstra , pi3orama@163.com, Sukadev Bhattiprolu , Zefan Li , Arnaldo Carvalho de Melo , Alexei Starovoitov Subject: Re: [GIT PULL 0/6] perf/core improvements and fixes Message-ID: <20150604072153.GA18983@gmail.com> References: <1433371238-14572-1-git-send-email-acme@kernel.org> <20150604054854.GA10969@gmail.com> <556FEB32.8040909@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <556FEB32.8040909@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2290 Lines: 57 * Wangnan (F) wrote: > On 2015/6/4 13:48, Ingo Molnar wrote: > >* Arnaldo Carvalho de Melo wrote: > > > >>Hi Ingo, > >> > >> Please consider applying. > >> > >> One of the next requests probably will have the eBPF work by Wang Nan, > >>but I am still going thru it and want to test it thoroughly. > >> > >> BTW: Have you looked at it lately? It is at: > >> > >>http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com > >> > >>Super summary from the above cover letter: > >> > >>--------------------- > >>It enables 'perf record' to filter events using eBPF programs like: > >> > >> # perf record --event bpf-file.o sleep 1 > >> > >>Events are selected and filtered according to definitions in bpf-file.o. > >Looks useful, but I think the UI needs one more tweak: could you fix it to be able > >to filter based on the eBPF _source_ file, not just the object file? > > > >People want to tweak such filters as they profile, so we should use the eBPF > >source code as the primary interface. We can compile it internally to the .o just > >fine. The .o file is a totally uninteresting intermediate product in itself. > > > >I.e. we need to first think through such profiling workflows from beginning to end > >before allowing them upstream. > > In a private mail Alexei Starovoitov disscussed with me about this. He said that > he is working on a shared object which can compile C program into BPF bytecode > on the fly. After he done his work, I think perf can support dtrace-like > profiling that, users will be able to feed source code to perf directly on > cmdline. He said he can release it on June. I added him to the CC-list. > > However I think the '.o' intermediate is still needed. [...] So how do you generate the .o? Why cannot the tool, if it sees that the filter parameter is eBPF source code, do that automatically? I.e. you are making the user jump through hoops for no good reason - that's a bad UI and a bad workflow. Please don't do that! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/