Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbbFDHse (ORCPT ); Thu, 4 Jun 2015 03:48:34 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:37109 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbbFDHsd (ORCPT ); Thu, 4 Jun 2015 03:48:33 -0400 Message-ID: <557002C3.5050303@linux.vnet.ibm.com> Date: Thu, 04 Jun 2015 13:18:19 +0530 From: Madhavan Srinivasan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Daniel Axtens CC: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Stephane Eranian , Paul Mackerras , Sukadev Bhattiprolu , Anshuman Khandual Subject: Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition References: <1433260778-26497-1-git-send-email-maddy@linux.vnet.ibm.com> <1433260778-26497-2-git-send-email-maddy@linux.vnet.ibm.com> <1433286663.438.10.camel@axtens.net> In-Reply-To: <1433286663.438.10.camel@axtens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060407-4790-0000-0000-00000886ACEF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 41 On Wednesday 03 June 2015 04:41 AM, Daniel Axtens wrote: >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + */ > I'm not certain about this, but I _think_ this is supposed to be version > 2 only: > http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9 I referred other files for license information from the same folder. So I could wait for the maintainers comment on this. > >> +/* >> + * Device tree parser code detect nest pmu support >> + * and create new nest pmus. This structure will >> + * hold the pmu functions and attrs for each nest pmu and >> + * will be referenced at the time of pmu registering. >> + */ > The first sentence of that comment is unclear: I think your trying to > say "Device tree parser code detects nest pmu support and registers new > nest pmus"? Also s/registering/registration/. Yes. I will rewrite the comment. >> +struct nest_pmu { >> + struct pmu pmu; >> + const struct attribute_group *attr_groups[4]; >> +}; >> + > Regards, > Daniel Axtens Thanks for the review Maddy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/