Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbbFDJSc (ORCPT ); Thu, 4 Jun 2015 05:18:32 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41753 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbbFDJSZ (ORCPT ); Thu, 4 Jun 2015 05:18:25 -0400 Date: Thu, 4 Jun 2015 10:16:35 +0100 From: Mark Brown To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , Vinod Koul , Dan Williams , David Woodhouse , Brian Norris , Han Xu , Geert Uytterhoeven , Marek Vasut , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , Bean Huo =?utf-8?B?6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Message-ID: <20150604091634.GY14071@sirena.org.uk> References: <305830ebf9c0ae98c4f6e0ebbdec7414d6762b36.1433364398.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+luzzTK7BKd/hj/D" Content-Disposition: inline In-Reply-To: <305830ebf9c0ae98c4f6e0ebbdec7414d6762b36.1433364398.git.hramrach@gmail.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/11] spi: add more debug prints in s3c64xx X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2270 Lines: 60 --+luzzTK7BKd/hj/D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 03, 2015 at 09:26:42PM -0000, Michal Suchanek wrote: > The SPI NOR transfers mysteriously fail so add more debug prints about > SPI transactions. Please try to only send patches to relevant people - the list of recipients for this is so large that it only barely fits on a single screen in my mail client. Also for this patch (which just adds some trace) there isn't any clear reason for it to be sent as part of the series at all, it doesn't help deliver the functionality and doesn't depend on the rest of the series. > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include Whatever you're doing here this indicates that there's a very big abstraction problem going on. > + pr_debug("%s %s %s waiting for %ims transferring %zubytes@%iHz", > + __func__, sdd->pdev ? dev_name(&sdd->pdev->dev) : NULL, > + dev_name(&sdd->master->dev), > + ms, xfer->len, sdd->cur_speed); I'd say dev_dbg() but more generally this is just tracing things that seem to be already covered by the trace points already present in the core, the same goes for most of the rest of it. If there's things missing from the existing trace it seems better to add to it. --+luzzTK7BKd/hj/D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcBdyAAoJECTWi3JdVIfQCnsH/3EO4Vu7AfB1/hgBGS5nixK1 1yBqIFZHwwyb2GWx5/Ori1jjzPy+UCFIN5F0zGlJ9yYjA6eGcwjAbHjhFAHNmjXG EF+Kn+bCF0OBc8YN7VaJyia90lYYmvkm1fG28O+gpxV2Z3z5a2hh1DkcGrXgbahF qVFn/4hywAEQsq7jOGod3gu8ozIO80RC8j8tbBKHikhZXsacJQlXDb4DZroo9VT/ gvU7nY1c5ZNIDjFvb6p7WWiF8laJLiBHBwYXUeukP5XqNRGsnzSwUt3pArIYFN4/ hAVyy1AHvIIh4DXoJ0vaynMS0X6YmkaCv53Dz+uK5PZrCNpsfbC50KlIoBjzkNI= =ltZS -----END PGP SIGNATURE----- --+luzzTK7BKd/hj/D-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/