Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbbFDJn5 (ORCPT ); Thu, 4 Jun 2015 05:43:57 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41827 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbbFDJnj (ORCPT ); Thu, 4 Jun 2015 05:43:39 -0400 Date: Thu, 4 Jun 2015 10:42:48 +0100 From: Mark Brown To: Geert Uytterhoeven Cc: Michal Suchanek , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , Vinod Koul , Dan Williams , David Woodhouse , Brian Norris , Han Xu , Geert Uytterhoeven , Marek Vasut , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , Bean Huo =?utf-8?B?6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , dmaengine@vger.kernel.org, MTD Maling List , linux-spi Message-ID: <20150604094248.GA14071@sirena.org.uk> References: <305830ebf9c0ae98c4f6e0ebbdec7414d6762b36.1433364398.git.hramrach@gmail.com> <20150604091634.GY14071@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="988dVgVOOB5COf1N" Content-Disposition: inline In-Reply-To: X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/11] spi: add more debug prints in s3c64xx X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1680 Lines: 46 --988dVgVOOB5COf1N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 04, 2015 at 11:30:15AM +0200, Geert Uytterhoeven wrote: > On Thu, Jun 4, 2015 at 11:16 AM, Mark Brown wrote: > >> --- a/drivers/spi/spi-s3c64xx.c > >> +++ b/drivers/spi/spi-s3c64xx.c > >> @@ -18,6 +18,7 @@ > >> #include > >> #include > >> #include > >> +#include > > Whatever you're doing here this indicates that there's a very big > > abstraction problem going on. > I guess it's needed for __clk_get_name(), which can be avoided by using > the "%pC" printf format specifier instead. Right, or by adding an externally usable API - the point is that using internal functions in a client driver is a big red flag. --988dVgVOOB5COf1N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcB2YAAoJECTWi3JdVIfQO6EH/2yX1CkVIi3J13r7qH1fI02p U4vHVMtnfVXqaWbob/bIt1vn/L8D8L5ojQ5l5p6AoRrXkb9p3XwMOTV4no8JuS1/ +F28Qy6+RFDcYGWcc8E5KvpNLWIreXEYx3J0NTvjtxzl1UIYHVs5RVlYflh2kmqj qn2Jsmy13TcGcohUAbQGFSG662iGeV+KdAsWwD2rql+awInCYJT1lwvUqkujEXJ9 eM+MxZn8ZgEUWoqEBzfGDZaahs/ORdgx9XgAOwPsimAsqYbTeN95L6o90x/TL5ZM IG3t6XBCgGwIWNLz0T/WzYO2n1T3d8TOH+ShqGbtpmMvTpyZ4Rt/XruByI00BO8= =qp8l -----END PGP SIGNATURE----- --988dVgVOOB5COf1N-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/