Date: Thu, 4 Jun 2015 12:07:41 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, umgwanakikbuti@gmail.com,
        mingo@elte.hu, ktkhai@parallels.com, rostedt@goodmis.org,
        juri.lelli@gmail.com, pang.xunlei@linaro.org, oleg@redhat.com,
        wanpeng.li@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] hrtimer: Allow hrtimer::function() to free the timer
Message-ID: <20150604100741.GG3644@twins.programming.kicks-ass.net>
References: <20150603132903.203333087@infradead.org>
 <20150603134023.156059118@infradead.org>
 <alpine.DEB.2.11.1506031917030.31424@nanos>
 <20150603212949.GD3644@twins.programming.kicks-ass.net>
 <20150604055930.GA13638@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150604055930.GA13638@gmail.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 972
Lines: 24

On Thu, Jun 04, 2015 at 07:59:30AM +0200, Ingo Molnar wrote:

> > --- a/include/linux/hrtimer.h
> > +++ b/include/linux/hrtimer.h
> > @@ -123,8 +123,10 @@ struct hrtimer_sleeper {
> >  
> >  #ifdef CONFIG_64BIT
> >  # define HRTIMER_CLOCK_BASE_ALIGN	64
> > +# define __timer_base_running(timer)	timer->base->running
> >  #else
> >  # define HRTIMER_CLOCK_BASE_ALIGN	32
> > +# define __timer_base_running(timer)	timer->base->cpu_base->running
> >  #endif
> 
> Please put it into the cpu_base on 64-bit as well: the base pointer is available 
> already on 64-bit so there should be no measurable performance difference, and 
> readability is a primary concern with all this code.

That's an extra pointer chase for no reason :-(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/