Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbbFDK1X (ORCPT ); Thu, 4 Jun 2015 06:27:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41879 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbFDK1M (ORCPT ); Thu, 4 Jun 2015 06:27:12 -0400 Date: Thu, 4 Jun 2015 11:26:21 +0100 From: Mark Brown To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , Vinod Koul , Dan Williams , David Woodhouse , Brian Norris , Han Xu , Geert Uytterhoeven , Marek Vasut , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , Bean Huo =?utf-8?B?6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , devicetree , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , dmaengine , linux-mtd@lists.infradead.org, linux-spi Message-ID: <20150604102621.GB14071@sirena.org.uk> References: <305830ebf9c0ae98c4f6e0ebbdec7414d6762b36.1433364398.git.hramrach@gmail.com> <20150604091634.GY14071@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5L/0NH1d7AMGItx" Content-Disposition: inline In-Reply-To: X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/11] spi: add more debug prints in s3c64xx X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2321 Lines: 54 --d5L/0NH1d7AMGItx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 04, 2015 at 11:33:37AM +0200, Michal Suchanek wrote: > On 4 June 2015 at 11:16, Mark Brown wrote: > > Also for this patch (which just adds some trace) there isn't any clear > > reason for it to be sent as part of the series at all, it doesn't help > > deliver the functionality and doesn't depend on the rest of the series. > I used this patch to add missing information to dmesg output so I > could diagnose the SPI failures so I think it is relevant. The fact that you used this to debug problems is not relevant to any fix you might have developed for those problems; the fix can be explained without needing to know how you got there. Similarly the debugging is hopefully useful in general without needing to know which particular problem prompted it's creation. > To print a clock name you AFAICT need this header. I think this is an > abstraction problem in the clock framework. Fixing the abstraction > problem with clock framework would only grow the list of recipients > which is already so long you complain about it. This is a bit of a warning sign that the series isn't very focused. It's also just not good practice, sending patches with obvious problems (especially obvious problems that aren't clearly flagged up as something temporary) will frustrate reviewers and can often lead to other issues being obscured. --d5L/0NH1d7AMGItx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcCfMAAoJECTWi3JdVIfQUqUH/R+Nlv9ELNPw+tGGYlunfVzE pZJBF4wKZFs3MkZX1tctiv2eJjQv2qimy62Z1DUvmctXq2KEopZMgcQfWeQrgG0U qxsYrvENti7NSigt7sWJ4yOurV2QY4M8Xej14XCe0ss96W56U2XQ8vwvQhqrbbr4 +t1Pwd6Evw5aL9BJdm+KS87owraQ2wdz2bs6H3gouVwzZ1Xg3NPYNjV10BP8uzqn trwS8HwLAg49bjmD5NlChj2JQCrx+5b2fVyugeIhIK5pMvVLGaaVmzkQJW4pjcrb yK4U3jT4AuVhzaNaiMHBxBUC6HQvS/ZIJvmT10BdRdX+9JGEqOLzlakEvbVpw/Y= =BZSM -----END PGP SIGNATURE----- --d5L/0NH1d7AMGItx-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/