Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbbFDKxJ (ORCPT ); Thu, 4 Jun 2015 06:53:09 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:34810 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbbFDKxB (ORCPT ); Thu, 4 Jun 2015 06:53:01 -0400 MIME-Version: 1.0 In-Reply-To: <20150604102621.GB14071@sirena.org.uk> References: <305830ebf9c0ae98c4f6e0ebbdec7414d6762b36.1433364398.git.hramrach@gmail.com> <20150604091634.GY14071@sirena.org.uk> <20150604102621.GB14071@sirena.org.uk> From: Michal Suchanek Date: Thu, 4 Jun 2015 12:52:19 +0200 Message-ID: Subject: Re: [PATCH 10/11] spi: add more debug prints in s3c64xx To: Mark Brown Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , Vinod Koul , Dan Williams , David Woodhouse , Brian Norris , Han Xu , Geert Uytterhoeven , Marek Vasut , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , =?UTF-8?B?QmVhbiBIdW8g6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , devicetree , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , dmaengine , MTD Maling List , linux-spi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 50 On 4 June 2015 at 12:26, Mark Brown wrote: > On Thu, Jun 04, 2015 at 11:33:37AM +0200, Michal Suchanek wrote: >> On 4 June 2015 at 11:16, Mark Brown wrote: > >> > Also for this patch (which just adds some trace) there isn't any clear >> > reason for it to be sent as part of the series at all, it doesn't help >> > deliver the functionality and doesn't depend on the rest of the series. > >> I used this patch to add missing information to dmesg output so I >> could diagnose the SPI failures so I think it is relevant. > > The fact that you used this to debug problems is not relevant to any fix > you might have developed for those problems; the fix can be explained > without needing to know how you got there. Similarly the debugging is > hopefully useful in general without needing to know which particular > problem prompted it's creation. Yes, this patch should be meaningful on its own. The ultimate purpose of this patch series is to make the SPI NOR flash chip usable on boards of which I have 1 sample. If the results on boards other than mine happen to be different the debug prints will be useful for users of this flash chip. There is no code interdependency with the other patches so if it's preferred I can send patches like this separately. > >> To print a clock name you AFAICT need this header. I think this is an >> abstraction problem in the clock framework. Fixing the abstraction >> problem with clock framework would only grow the list of recipients >> which is already so long you complain about it. > > This is a bit of a warning sign that the series isn't very focused. > It's also just not good practice, sending patches with obvious problems > (especially obvious problems that aren't clearly flagged up as something > temporary) will frustrate reviewers and can often lead to other issues > being obscured. As has been pointed out public interface already exists for getting the clock name so the issue here is cosmetic. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/