Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbbFDLab (ORCPT ); Thu, 4 Jun 2015 07:30:31 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:34131 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181AbbFDLaa (ORCPT ); Thu, 4 Jun 2015 07:30:30 -0400 MIME-Version: 1.0 In-Reply-To: <1433414370-17557-3-git-send-email-sergei@s15v.net> References: <1433414370-17557-3-git-send-email-sergei@s15v.net> Date: Thu, 4 Jun 2015 13:30:29 +0200 Message-ID: Subject: Re: [PATCH] kdbus: use FIELD_SIZEOF in kdbus_member_set_user macro From: David Herrmann To: Sergei Zviagintsev Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 39 Hi On Thu, Jun 4, 2015 at 12:39 PM, Sergei Zviagintsev wrote: > sizeof(((_t *)0)->_m) -> FIELD_SIZEOF(_t, _m) > > Use conventional macro according to chapter 17 of > Documentation/CodingStyle. > > Signed-off-by: Sergei Zviagintsev > --- > ipc/kdbus/util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: David Herrmann Thanks David > diff --git a/ipc/kdbus/util.h b/ipc/kdbus/util.h > index 9fedf8ab41cd..529716669fe7 100644 > --- a/ipc/kdbus/util.h > +++ b/ipc/kdbus/util.h > @@ -40,7 +40,7 @@ > ({ \ > u64 __user *_sz = \ > (void __user *)((u8 __user *)(_b) + offsetof(_t, _m)); \ > - copy_to_user(_sz, _s, sizeof(((_t *)0)->_m)); \ > + copy_to_user(_sz, _s, FIELD_SIZEOF(_t, _m)); \ > }) > > /** > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/