Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbbFDMgu (ORCPT ); Thu, 4 Jun 2015 08:36:50 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:54039 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752777AbbFDMgt (ORCPT ); Thu, 4 Jun 2015 08:36:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3870:3871:3872:3873:3874:4250:4321:4605:5007:6261:7903:10004:10226:10400:10848:11232:11658:11914:12517:12519:12740:13069:13095:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: club78_3b42de6d3f95b X-Filterd-Recvd-Size: 2062 Message-ID: <1433421406.4861.173.camel@perches.com> Subject: Re: [PATCH 1/3] checkpatch: Improve output with multiple command-line files From: Joe Perches To: Petr Mladek Cc: Andrew Morton , Andy Whitcroft , linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2015 05:36:46 -0700 In-Reply-To: <20150604122903.GQ3135@pathway.suse.cz> References: <20150604120328.GN3135@pathway.suse.cz> <1433420079.4861.169.camel@perches.com> <20150604122903.GQ3135@pathway.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 32 On Thu, 2015-06-04 at 14:29 +0200, Petr Mladek wrote: > On Thu 2015-06-04 05:14:39, Joe Perches wrote: > > On Thu, 2015-06-04 at 14:03 +0200, Petr Mladek wrote: > > > On Wed 2015-06-03 08:53:38, Joe Perches wrote: [] > > > > +NOTE: Whitespace errors detected. > > > > + You may wish to use scripts/cleanpatch or scripts/cleanfile > > > > +EOM > > > > > > It would make sense to write this message only once as well. > > > > I don't think so as it applies to each patch/file separately. > > IMHO, it advertises scripts/cleanpatch or scripts/cleanfile. I think > that we do not need to repeat it for each affected patch. No worries, we just disagree. > In fact, using scripts/cleanfile is questionable. IMHO, it does not > make sense to fix indentation just because it looks better. It makes > problems when backporting fixes. But it might make sense to fix it > when you do some real change on that line. Whitespace at EOL backporting is trivially handled by git am. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/