Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbbFDMqs (ORCPT ); Thu, 4 Jun 2015 08:46:48 -0400 Received: from smtp.citrix.com ([66.165.176.89]:6982 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486AbbFDMqp (ORCPT ); Thu, 4 Jun 2015 08:46:45 -0400 X-IronPort-AV: E=Sophos;i="5.13,552,1427760000"; d="scan'208";a="268916082" Message-ID: <557048B1.9070805@citrix.com> Date: Thu, 4 Jun 2015 13:46:41 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Julien Grall , Joe Perches CC: , , , , "Konrad Rzeszutek Wilk" , Boris Ostrovsky , Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses References: <1433350510-12846-1-git-send-email-julien.grall@citrix.com> <1433350510-12846-2-git-send-email-julien.grall@citrix.com> <1433351196.4861.131.camel@perches.com> <5570484C.8040201@citrix.com> In-Reply-To: <5570484C.8040201@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 33 On 04/06/15 13:45, Julien Grall wrote: > On 03/06/15 18:06, Joe Perches wrote: >> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: >>> rx->status is an int16_t, print it using %d rather than %u in order to >>> have a meaningful value when the field is negative. >> [] >>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> [] >>> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue, >>> if (unlikely(rx->status < 0 || >>> rx->offset + rx->status > PAGE_SIZE)) { >>> if (net_ratelimit()) >>> - dev_warn(dev, "rx->offset: %x, size: %u\n", >>> + dev_warn(dev, "rx->offset: %x, size: %d\n", >> >> If you're going to do this, perhaps it'd be sensible to >> also change the %x to %#x or 0x%x so that people don't >> mistake offset without an [a-f] for decimal. > > Good idea. I will resend a version of this series. > > David, can I keep you Reviewed-by for this change?# Can you make the offset %d instead? You can keep the reviewed-by if you do this. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/