Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753380AbbFDNpR (ORCPT ); Thu, 4 Jun 2015 09:45:17 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35188 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbbFDNpP (ORCPT ); Thu, 4 Jun 2015 09:45:15 -0400 MIME-Version: 1.0 From: Valentin Rothberg Date: Thu, 4 Jun 2015 15:44:43 +0200 Message-ID: Subject: drm/amdkfd: bad CONFIG_ prefix for enum entries To: yair.shachar@amd.com Cc: Paul Bolle , Andreas Ruprecht , hengelein Stefan , oded.gabbay@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 30 Hi Yair, your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger module support") has shown up in today's linux-next tree (i.e., next-20150604). The commit adds the following lines of code to drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h: +/* CONFIG reg space definition */ +enum { + CONFIG_REG_BASE = 0x2000, /* in dwords */ + CONFIG_REG_END = 0x2B00, + CONFIG_REG_SIZE = CONFIG_REG_END - CONFIG_REG_BASE +}; There is a problem with the 'CONFIG_' prefix of those entries. This prefix is reserved for Kconfig options in Make/Kbuild and CPP syntax, so that static analysis tools (and readers of the code) may mistakenly assume that the symbol is defined somewhere in a Kconfig file. I detected the issue with ./scripts/checkkconfigsymbols.py. Would you mind renaming those entries to something without the 'CONFIG_' prefix? I can also take care of it if you wish to. Kind regards, Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/