Date: Thu, 4 Jun 2015 16:53:13 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>, joe@perches.com,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] staging: rtl8192e: Remove dead code:
 dig_t::dbg_mode
Message-ID: <20150604135312.GG28762@mwanda>
References: <1433278095-13988-1-git-send-email-mateusz.kulikowski@gmail.com>
 <1433278095-13988-8-git-send-email-mateusz.kulikowski@gmail.com>
 <20150603072642.GA6897@sudip-PC>
 <556F458E.20002@gmail.com>
 <20150604051753.GA6376@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150604051753.GA6376@sudip-PC>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 24

On Thu, Jun 04, 2015 at 10:48:08AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
> > On 03.06.2015 09:26, Sudip Mukherjee wrote:
> > > On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
> > 
> > No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
> > Thanks for finding it - I'll fix that in v2.
> > 
> > Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?
> 
> at a first glance looked ok to me. I hope you have checked it on the
> hardware as well. but maybe Dan can find something.
> better send v2.

No.  Good job finding that bug.  I had missed it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/