Date: Thu, 4 Jun 2015 16:04:12 +0200
From: Ingo Molnar <mingo@kernel.org>
To: pi3orama <pi3orama@163.com>
Cc: "Wangnan (F)" <wangnan0@huawei.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexei Starovoitov <ast@plumgrid.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        David Ahern <dsahern@gmail.com>, He Kuang <hekuang@huawei.com>,
        Jiri Olsa <jolsa@redhat.com>, Kaixu Xia <xiakaixu@huawei.com>,
        Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        Zefan Li <lizefan@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [GIT PULL 0/6] perf/core improvements and fixes
Message-ID: <20150604140412.GB14445@gmail.com>
References: <1433371238-14572-1-git-send-email-acme@kernel.org>
 <20150604054854.GA10969@gmail.com>
 <556FEB32.8040909@huawei.com>
 <20150604072153.GA18983@gmail.com>
 <557021D3.7070900@huawei.com>
 <20150604124033.GA10580@gmail.com>
 <0108CD89-BFFA-4A68-90AE-A34597777641@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0108CD89-BFFA-4A68-90AE-A34597777641@163.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1462
Lines: 56


* pi3orama <pi3orama@163.com> wrote:

> 
> 
> 发自我的 iPhone
> 
> > 在 2015年6月4日，下午8:40，Ingo Molnar <mingo@kernel.org> 写道：
> > 
> > 
> > * Wangnan (F) <wangnan0@huawei.com> wrote:
> > 
> >>> So how do you generate the .o? Why cannot the tool, if it sees that the filter 
> >>> parameter is eBPF source code, do that automatically?
> >> 
> >> I think compiling on the fly is our goal, and Alexei is working on it.
> > 
> > So what exact command line are you using to create the .o?
> > 
> > What exactly should users type to create a simple eBPF filter profile?
> 
> I have mentioned in previous mail:
> 
> Use
> 
>  # perf record -e bpf_source.c cmdline 
> 
>  to create a eBPF filter from source,
> 
> Use
> 
> # perf record -e bpf_object.o cmdline 
> 
> to create a eBPF filter from object intermedia.
> 
> Use
> 
> # perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
> 
> to create the .o
> 
> I think this should be enough. Currently only the second case has been implemented.

So if users cannot actually generate .o files then it's premature to merge this in 
such an incomplete form!

It should be possible to use a feature that we are merging.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/