Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753575AbbFDOF3 (ORCPT ); Thu, 4 Jun 2015 10:05:29 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38270 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbbFDOF1 (ORCPT ); Thu, 4 Jun 2015 10:05:27 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Valentin Rothberg Date: Thu, 4 Jun 2015 16:04:55 +0200 Message-ID: Subject: Re: drm/amdkfd: bad CONFIG_ prefix for enum entries To: Alex Deucher Cc: Oded Gabbay , yair.shachar@amd.com, Paul Bolle , Andreas Ruprecht , Maling list - DRI developers , LKML , hengelein Stefan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2160 Lines: 63 Hi Alex, On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher wrote: > On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay wrote: >> Hi Valentin, >> Thanks for catching that. >> I would be grateful if you could fix this yourself. > > Please try and keep CONFIG in the name since this range of registers > are called CONFIG registers. I cannot force changing those symbols, but point out that it's violating naming conventions. I would suggest to s/CONFIG_/CONF_/ to make clear that it's config registers. Would you be fine with that? Kind regards, Valentin > Alex > >> >> Oded >> >> On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg >> wrote: >>> >>> Hi Yair, >>> >>> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger >>> module support") has shown up in today's linux-next tree (i.e., >>> next-20150604). The commit adds the following lines of code to >>> drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h: >>> >>> +/* CONFIG reg space definition */ >>> +enum { >>> + CONFIG_REG_BASE = 0x2000, /* in dwords */ >>> + CONFIG_REG_END = 0x2B00, >>> + CONFIG_REG_SIZE = CONFIG_REG_END - CONFIG_REG_BASE >>> +}; >>> >>> There is a problem with the 'CONFIG_' prefix of those entries. This >>> prefix is reserved for Kconfig options in Make/Kbuild and CPP syntax, >>> so that static analysis tools (and readers of the code) may mistakenly >>> assume that the symbol is defined somewhere in a Kconfig file. >>> >>> I detected the issue with ./scripts/checkkconfigsymbols.py. Would you >>> mind renaming those entries to something without the 'CONFIG_' prefix? >>> I can also take care of it if you wish to. >>> >>> Kind regards, >>> Valentin >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/