Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbbFDObY (ORCPT ); Thu, 4 Jun 2015 10:31:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34521 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbbFDObX (ORCPT ); Thu, 4 Jun 2015 10:31:23 -0400 From: Bandan Das To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, alex.williamson@redhat.com Subject: Re: [PATCH] kvm: x86: default legacy PCI device assignment support to "n" References: <1433405164-2484-1-git-send-email-pbonzini@redhat.com> Date: Thu, 04 Jun 2015 10:31:21 -0400 In-Reply-To: <1433405164-2484-1-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 4 Jun 2015 10:06:04 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 44 Paolo Bonzini writes: > VFIO has proved itself a much better option than KVM's built-in > device assignment. It is mature, provides better isolation because > it enforces ACS, and even the userspace code is being tested on > a wider variety of hardware these days than the legacy support. > > Disable legacy device assignment by default. Shouldn't we mark it as Deprecated then ? Bandan > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/Kconfig | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > index 413a7bf9efbb..a0f06a5947c5 100644 > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -88,13 +88,14 @@ config KVM_MMU_AUDIT > config KVM_DEVICE_ASSIGNMENT > bool "KVM legacy PCI device assignment support" > depends on KVM && PCI && IOMMU_API > - default y > + default n > ---help--- > Provide support for legacy PCI device assignment through KVM. The > kernel now also supports a full featured userspace device driver > - framework through VFIO, which supersedes much of this support. > + framework through VFIO, which supersedes this support and provides > + better security. > > - If unsure, say Y. > + If unsure, say N. > > # OK, it's a little counter-intuitive to do this, but it puts it neatly under > # the virtualization menu. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/