Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbbFDOlG (ORCPT ); Thu, 4 Jun 2015 10:41:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37676 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbbFDOlD (ORCPT ); Thu, 4 Jun 2015 10:41:03 -0400 Date: Thu, 4 Jun 2015 16:40:54 +0200 From: Andrew Jones To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Christoffer Dall , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de, Catalin Marinas , Will Deacon , open list Subject: Re: [PATCH v5 03/12] KVM: arm64: guest debug, define API headers Message-ID: <20150604144054.GD2860@hawk.localdomain> References: <1432891828-4816-1-git-send-email-alex.bennee@linaro.org> <1432891828-4816-4-git-send-email-alex.bennee@linaro.org> <20150604110732.GG7657@cbox> <878ubzbn36.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878ubzbn36.fsf@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3695 Lines: 116 On Thu, Jun 04, 2015 at 02:49:17PM +0100, Alex Benn?e wrote: > > Christoffer Dall writes: > > > On Fri, May 29, 2015 at 10:30:19AM +0100, Alex Benn?e wrote: > >> This commit defines the API headers for guest debugging. There are two > >> architecture specific debug structures: > >> > >> - kvm_guest_debug_arch, allows us to pass in HW debug registers > >> - kvm_debug_exit_arch, signals exception and possible faulting address > >> > >> The type of debugging being used is controlled by the architecture > >> specific control bits of the kvm_guest_debug->control flags in the ioctl > >> structure. > >> > >> Signed-off-by: Alex Benn?e > >> Reviewed-by: David Hildenbrand > >> Reviewed-by: Andrew Jones > >> Acked-by: Christoffer Dall > > > > I can re-confirm my ack despite the changes in v4, but this really is > > borderline to keep exiting r-b and a-b tags around from previous patches > > I would think, but ok. > > I was wondering how much a patch has to change for the r-b tags to > become invalid. The meat of the API hasn't changed much though. > > Drew/David, > > Are you still happy with this patch? I'm fine with it. Sorry I haven't had time to look over the rest of the series yet this round. drew > > > > > -Christoffer > > > >> > >> --- > >> v2 > >> - expose hsr and pc directly to user-space > >> v3 > >> - s/control/controlled/ in commit message > >> - add v8 to ARM ARM comment (ARM Architecture Reference Manual) > >> - add rb tag > >> - rm pc, add far > >> - re-word comments on alignment > >> - rename KVM_ARM_NDBG_REGS -> KVM_ARM_MAX_DBG_REGS > >> v4 > >> - now uses common HW/SW BP define > >> - add a-b-tag > >> - use u32 for control regs > >> v5 > >> - revert to have arch specific KVM_GUESTDBG_USE_SW/HW_BP > >> - rm stale comments dbgctrl was stored as u64 > >> --- > >> arch/arm64/include/uapi/asm/kvm.h | 20 ++++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > >> > >> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > >> index d268320..43758e7 100644 > >> --- a/arch/arm64/include/uapi/asm/kvm.h > >> +++ b/arch/arm64/include/uapi/asm/kvm.h > >> @@ -100,12 +100,32 @@ struct kvm_sregs { > >> struct kvm_fpu { > >> }; > >> > >> +/* > >> + * See v8 ARM ARM D7.3: Debug Registers > >> + * > >> + * The architectural limit is 16 debug registers of each type although > >> + * in practice there are usually less (see ID_AA64DFR0_EL1). > >> + */ > >> +#define KVM_ARM_MAX_DBG_REGS 16 > >> struct kvm_guest_debug_arch { > >> + __u32 dbg_bcr[KVM_ARM_MAX_DBG_REGS]; > >> + __u64 dbg_bvr[KVM_ARM_MAX_DBG_REGS]; > >> + __u32 dbg_wcr[KVM_ARM_MAX_DBG_REGS]; > >> + __u64 dbg_wvr[KVM_ARM_MAX_DBG_REGS]; > >> }; > >> > >> struct kvm_debug_exit_arch { > >> + __u32 hsr; > >> + __u64 far; > >> }; > >> > >> +/* > >> + * Architecture specific defines for kvm_guest_debug->control > >> + */ > >> + > >> +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > >> +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) > >> + > >> struct kvm_sync_regs { > >> }; > >> > >> -- > >> 2.4.1 > >> > > -- > Alex Benn?e > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/