Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121AbbFDOmS (ORCPT ); Thu, 4 Jun 2015 10:42:18 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:33482 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbFDOmO (ORCPT ); Thu, 4 Jun 2015 10:42:14 -0400 Message-ID: <1433428930.15728.18.camel@x220> Subject: Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device From: Paul Bolle To: Yaniv Gardi Cc: James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinayak Holikatti , "James E.J. Bottomley" , Dolev Raviv , Christoph Hellwig , Sujit Reddy Thumma , Raviv Shvili , Sahitya Tummala , "open list:OPEN FIRMWARE AND..." Date: Thu, 04 Jun 2015 16:42:10 +0200 In-Reply-To: <1433426833.15728.15.camel@x220> References: <1433324255-27510-1-git-send-email-ygardi@codeaurora.org> <1433324255-27510-5-git-send-email-ygardi@codeaurora.org> <1433426833.15728.15.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 19 On Thu, 2015-06-04 at 16:07 +0200, Paul Bolle wrote: > On Wed, 2015-06-03 at 12:37 +0300, Yaniv Gardi wrote: > > +static int ufs_qcom_probe(struct platform_device *pdev) > > +{ > > + dev_set_drvdata(&pdev->dev, (void *)&ufs_hba_qcom_vops); > > (Cast to void * should not be needed.) Only if ufs_hba_qcom_vops wasn't a _const_ struct ufs_hba_variant_ops, that is. Never mind. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/