Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbbFDUal (ORCPT ); Thu, 4 Jun 2015 16:30:41 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:33270 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbbFDUak (ORCPT ); Thu, 4 Jun 2015 16:30:40 -0400 Date: Fri, 5 Jun 2015 05:30:34 +0900 From: Tejun Heo To: Rusty Russell Cc: Louis Langholtz , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be? Message-ID: <20150604203034.GS20091@mtj.duckdns.org> References: <87vbf628uy.fsf@rustcorp.com.au> <7E8FFE0D-B9F7-4816-8ECF-2AA5980F3890@me.com> <20150603202237.GI20091@mtj.duckdns.org> <87eglsuujn.fsf@rustcorp.com.au> <20150604021935.GN20091@mtj.duckdns.org> <878ubzuuhe.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878ubzuuhe.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 22 On Fri, Jun 05, 2015 at 05:16:53AM +0930, Rusty Russell wrote: > Tejun Heo writes: > > On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote: > >> Please describe the circumstances under which this function can fail. > > > > Allocation failure obviously > > Won't happen here, this is a boot-time function. version_sysfs_builtin. > The __init is the clue. Yes, that's this one callsite. There are whole others which can fail. Just add WARN_ON here. What are you arguing? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/