Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbbFDWSD (ORCPT ); Thu, 4 Jun 2015 18:18:03 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42892 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753224AbbFDWR6 (ORCPT ); Thu, 4 Jun 2015 18:17:58 -0400 Date: Fri, 5 Jun 2015 00:17:56 +0200 From: Alexandre Belloni To: Philippe Reynes Cc: shawn.guo@linaro.org, kernel@pengutronix.de, linux@arm.linux.org.uk, a.zummo@towertech.it, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, fabio.estevam@freescale.com Subject: Re: [PATCH 1/2] rtc: mxc: add a second clock Message-ID: <20150604221756.GD713@piout.net> References: <1431729330-7625-1-git-send-email-tremyfr@gmail.com> <1431729330-7625-2-git-send-email-tremyfr@gmail.com> <20150528115731.GN2185@piout.net> <5570BE33.9080103@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5570BE33.9080103@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 20 On 04/06/2015 at 23:08:03 +0200, Philippe Reynes wrote : > >You are getting the rate but don't you need to clk_prepare_enable()? > > This IP needs the clock reference rate for his configuration, > so I think that I only need the rate. > I think we need to check whether we are guaranteed to get a result from get_rate even if the clock is not enabled. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/