Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932272AbbFDXDA (ORCPT ); Thu, 4 Jun 2015 19:03:00 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:48322 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbbFDXC5 (ORCPT ); Thu, 4 Jun 2015 19:02:57 -0400 Subject: [Fwd: Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq] From: "Hon Ching (Vicky) Lo" To: PeterHuewe@gmx.de Cc: tpmdd-devel@lists.sourceforge.net, Joy Latten , Vicky Lo , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Date: Thu, 04 Jun 2015 19:02:44 -0400 Message-ID: <1433458964.22246.9.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060423-0021-0000-0000-0000059EA550 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 71 Hi Peter, Would it be possible for you to review and commit the following patch at your earliest convenience? Thanks in advance! -------- Forwarded Message -------- From: Ashley Lai To: Hon Ching(Vicky) Lo Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten Subject: Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq Date: Tue, 2 Jun 2015 00:50:43 -0500 (CDT) Thanks for the patch. Looks good to me. Reviewed-by: Ashley Lai --Ashley Lai On Fri, 22 May 2015, Hon Ching(Vicky) Lo wrote: > tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet > set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq, > the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address. > > Signed-off-by: Hon Ching(Vicky) Lo > Signed-off-by: Joy Latten > --- > drivers/char/tpm/tpm_ibmvtpm.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index 42ffa5e..27ebf95 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -578,6 +578,9 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > goto cleanup; > } > > + ibmvtpm->dev = dev; > + ibmvtpm->vdev = vio_dev; > + > crq_q = &ibmvtpm->crq_queue; > crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL); > if (!crq_q->crq_addr) { > @@ -622,8 +625,6 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > > crq_q->index = 0; > > - ibmvtpm->dev = dev; > - ibmvtpm->vdev = vio_dev; > TPM_VPRIV(chip) = (void *)ibmvtpm; > > spin_lock_init(&ibmvtpm->rtce_lock); > -- > 1.7.1 > > Best Regards, Vicky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/