From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <htejun@gmail.com>
Cc: Louis Langholtz <lou_langholtz@me.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?
In-Reply-To: <20150604203034.GS20091@mtj.duckdns.org>
References: <FFF42EF7-42DB-4D5C-9C86-D8773E20D255@me.com> <87vbf628uy.fsf@rustcorp.com.au> <7E8FFE0D-B9F7-4816-8ECF-2AA5980F3890@me.com> <20150603202237.GI20091@mtj.duckdns.org> <87eglsuujn.fsf@rustcorp.com.au> <20150604021935.GN20091@mtj.duckdns.org> <878ubzuuhe.fsf@rustcorp.com.au> <20150604203034.GS20091@mtj.duckdns.org>
User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu)
Date: Fri, 05 Jun 2015 10:09:29 +0930
Message-ID: <87oakvt2da.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 28

Tejun Heo <htejun@gmail.com> writes:
> On Fri, Jun 05, 2015 at 05:16:53AM +0930, Rusty Russell wrote:
>> Tejun Heo <htejun@gmail.com> writes:
>> > On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote:
>> >> Please describe the circumstances under which this function can fail.
>> >
>> > Allocation failure obviously
>> 
>> Won't happen here, this is a boot-time function.  version_sysfs_builtin.
>> The __init is the clue.
>
> Yes, that's this one callsite.  There are whole others which can fail.
> Just add WARN_ON here.  What are you arguing?

What will a second warning which is never triggered achieve?  A bit of
code bloat and confusion, when I really do want to ignore the value.

I've asked (again) for gcc to allow cast to void:

        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/