Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932168AbbFEBo6 (ORCPT ); Thu, 4 Jun 2015 21:44:58 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34952 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450AbbFEBo5 (ORCPT ); Thu, 4 Jun 2015 21:44:57 -0400 From: Grant Likely Subject: Re: of/dynamic: Fix test for PPC_PSERIES To: Michael Ellerman , Geert Uytterhoeven , Rob Herring , Paul Mackerras , Benjamin Herrenschmidt Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , nfont@linux.vnet.ibm.com In-Reply-To: <20150604105732.77DFE140273@ozlabs.org> References: <20150604105732.77DFE140273@ozlabs.org> Date: Fri, 05 Jun 2015 10:44:48 +0900 Message-Id: <20150605014448.8C8C5C407BD@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 40 On Thu, 4 Jun 2015 20:57:32 +1000 (AEST) , Michael Ellerman wrote: > On Thu, 2015-04-06 at 09:34:41 UTC, Geert Uytterhoeven wrote: > > "IS_ENABLED(PPC_PSERIES)" always evaluates to false, as IS_ENABLED() is > > supposed to be used with the full Kconfig symbol name, including the > > "CONFIG_" prefix. > > > > Add the missing "CONFIG_" prefix to fix this. > > > > Fixes: a25095d451ece23b ("of: Move dynamic node fixups out of powerpc and into common code") > > Signed-off-by: Geert Uytterhoeven > > --- > > > Did this bug cause any breakage? > > If yes, the fix should go to stable (for v3.17 and later). > > Yikes. Not that I've heard of. But it's reasonably new so possibly it's not hit > distros that folks tend to run on those machines. > > I'm also not clear how it would break, it could be subtle and we've not noticed. > > Nathan might have more of an idea (on CC). > > On my machine here everything that has an ibm,phandle also has a linux,phandle, > so we wouldn't hit that code path. But I'm not sure how representative that box > is. > > cheers Still, an obvious bug. I've picked it up and marked for stable. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/