Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbbFEB46 (ORCPT ); Thu, 4 Jun 2015 21:56:58 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:24761 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbFEB44 (ORCPT ); Thu, 4 Jun 2015 21:56:56 -0400 Message-ID: <55710132.4070602@huawei.com> Date: Fri, 5 Jun 2015 09:53:54 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: "Luck, Tony" CC: Andrew Morton , "nao.horiguchi@gmail.com" , Yinghai Lu , "H. Peter Anvin" , Thomas Gleixner , "mingo@elte.hu" , Xiexiuqi , Hanjun Guo , Linux MM , LKML Subject: Re: [RFC PATCH 02/12] mm: introduce mirror_info References: <55704A7E.5030507@huawei.com> <55704B55.1020403@huawei.com> <3908561D78D1C84285E8C5FCA982C28F32A8D57F@ORSMSX114.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A8D57F@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 46 On 2015/6/5 0:57, Luck, Tony wrote: > +#ifdef CONFIG_MEMORY_MIRROR > +struct numa_mirror_info { > + int node; > + unsigned long start; > + unsigned long size; > +}; > + > +struct mirror_info { > + int count; > + struct numa_mirror_info info[MAX_NUMNODES]; > +}; > > Do we really need this? My patch series leaves all the mirrored memory in > the memblock allocator tagged with the MEMBLOCK_MIRROR flag. Can't > we use that information when freeing the boot memory into the runtime > free lists? > Hi Tony, I used this code for testing before, so when your patchset added to mainline, I'll rewrite it, use MEMBLOCK_MIRROR, not mirror_info. I find Andrew has added your patches to mm-tree, right? Thanks, Xishi Qiu > If we can't ... then [MAX_NUMNODES] may not be enough. We may have > more than one mirrored range on each node. Current h/w allows two ranges > per node. > > -Tony > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/