Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634AbbFEJDM (ORCPT ); Fri, 5 Jun 2015 05:03:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18311 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333AbbFEJDG (ORCPT ); Fri, 5 Jun 2015 05:03:06 -0400 Date: Fri, 5 Jun 2015 12:02:00 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , "John L. Hammond" , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH v3 1/8] staging:lustre: assume a kernel build Message-ID: <20150605090200.GL28762@mwanda> References: <1433364207-14307-1-git-send-email-jsimmons@infradead.org> <1433364207-14307-2-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433364207-14307-2-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 29 This whole patchset looks find to me. Some tips for the future. On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote: > From: John L. Hammond > > In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that > __KERNEL__ is defined). Remove some common code only needed for user > space LNet. > > - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, > - sizeof(lnet_me_t)); > + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0); When I'm reviewing "delete code" patches, I pretty much focus on the plus lines like this one. Obviously, I can figure out why we changed the parameters to zero but it saves me time if it's spelled out in the changelog. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/