Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754483AbbFEJDX (ORCPT ); Fri, 5 Jun 2015 05:03:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32536 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbbFEJDU (ORCPT ); Fri, 5 Jun 2015 05:03:20 -0400 Date: Fri, 5 Jun 2015 12:02:27 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers Message-ID: <20150605090226.GM28762@mwanda> References: <1433364207-14307-1-git-send-email-jsimmons@infradead.org> <1433364207-14307-6-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433364207-14307-6-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 33 On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote: > Currently the lnet headers used by user land contain various internal > LNet structures that are only used by kernel space. Move the user land > structures to headers used by user land. The kernel structures are > relocated to headers that are never exposed to user land. > > Signed-off-by: James Simmons > --- > diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c > index 1dc7c8a..4928f5c 100644 > --- a/drivers/staging/lustre/lnet/lnet/acceptor.c > +++ b/drivers/staging/lustre/lnet/lnet/acceptor.c > @@ -243,8 +243,6 @@ lnet_accept(struct socket *sock, __u32 magic) > > if (magic == le32_to_cpu(LNET_PROTO_TCP_MAGIC)) > str = "'old' socknal/tcpnal"; > - else if (lnet_accept_magic(magic, LNET_PROTO_RA_MAGIC)) > - str = "'old' ranal"; > else > str = "unrecognised"; > Presumably this was done intentionally. We deleted LNET_PROTO_RA_MAGIC. The changelog was not very clear why. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/