Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932660AbbFEJFH (ORCPT ); Fri, 5 Jun 2015 05:05:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33506 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932332AbbFEJFD (ORCPT ); Fri, 5 Jun 2015 05:05:03 -0400 Date: Fri, 5 Jun 2015 12:04:33 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH v3 7/8] staging:lustre: style cleanups for LNet headers Message-ID: <20150605090433.GO28762@mwanda> References: <1433364207-14307-1-git-send-email-jsimmons@infradead.org> <1433364207-14307-8-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433364207-14307-8-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 40 I'm fine with merging this patch as is. On Wed, Jun 03, 2015 at 04:43:26PM -0400, James Simmons wrote: > + struct lnet_peer *msg_txpeer; /* peer I'm sending to */ > + struct lnet_peer *msg_rxpeer; /* peer I received from */ > + > + void *msg_private; > + struct lnet_libmd *msg_md; > + > + unsigned int msg_len; > + unsigned int msg_wanted; > + unsigned int msg_offset; > + unsigned int msg_niov; > + struct kvec *msg_iov; > + lnet_kiov_t *msg_kiov; > + > + lnet_event_t msg_ev; > + lnet_hdr_t msg_hdr; These aren't in "lustre style". Lustre style is more like: unsigned int msg_len; unsigned int msg_wanted; unsigned int msg_offset; unsigned int msg_niov; struct kvec *msg_iov; lnet_kiov_t *msg_kiov; We're going through and re-indenting things. I think just one space between type and name is the right thing for .c files but you guys really should figure out what style you're using for your header files. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/