Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbbFEJbg (ORCPT ); Fri, 5 Jun 2015 05:31:36 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:33866 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbbFEJbe (ORCPT ); Fri, 5 Jun 2015 05:31:34 -0400 MIME-Version: 1.0 In-Reply-To: <20150605091713.GD6826@codeblueprint.co.uk> References: <1432712748-11344-1-git-send-email-ethan.zhao@oracle.com> <20150605091713.GD6826@codeblueprint.co.uk> Date: Fri, 5 Jun 2015 11:31:32 +0200 Message-ID: Subject: Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI From: David Herrmann To: Matt Fleming Cc: Ethan Zhao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Fabian Frederick , "the arch/x86 maintainers" , linux-kernel , ethan.kernel@gmail.com, linux-efi@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2316 Lines: 59 Hi On Fri, Jun 5, 2015 at 11:17 AM, Matt Fleming wrote: > (Cc'ing David) > > On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote: >> As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 >> When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and >> login on console. >> >> Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so >> skip it. >> >> This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9 >> with kernel 4.0.4 >> >> Signed-off-by: Ethan Zhao >> Tested-by: Kunlun Lao >> --- >> arch/x86/kernel/sysfb_simplefb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c >> index 764a29f..f833502 100644 >> --- a/arch/x86/kernel/sysfb_simplefb.c >> +++ b/arch/x86/kernel/sysfb_simplefb.c >> @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si, >> unsigned int i; >> >> type = si->orig_video_isVGA; >> - if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI) >> + if (type != VIDEO_TYPE_VLFB) >> return false; >> >> for (i = 0; i < ARRAY_SIZE(formats); ++i) { > > This patch makes sense to me, but I'd really like David to fill us in on > the rationale for including VIDEO_TYPE_EFI in the simplefb list in first > place, and whether he's aware of any platforms that require simplefb for > UEFI. simplefb works perfectly fine on EFI systems. There is no need to use vesafb nor efifb anymore. If simplefb does not work on a platform, we should fix it. Hence, I object to this patch. Can you elaborate what exactly the problem is? Are you sure you have CONFIG_FB_SIMPLE=y? If you really want to use efifb instead, please set CONFIG_X86_SYSFB=n. This config option controls whether you want firmware framebuffers to be converted to the generic simple-framebuffer interface, or whether you want to use the old vesa/efi-framebuffer interfaces. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/