Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbbFEKDK (ORCPT ); Fri, 5 Jun 2015 06:03:10 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:1882 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbbFEKDH (ORCPT ); Fri, 5 Jun 2015 06:03:07 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 05 Jun 2015 02:59:14 -0700 Date: Fri, 5 Jun 2015 12:02:40 +0200 From: Thierry Reding To: Doug Anderson CC: Philipp Zabel , Russell King , , , , , , Subject: Re: [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes Message-ID: <20150605100237.GC6436@ulmo.nvidia.com> References: <1433441076-20049-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 In-Reply-To: <1433441076-20049-1-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.2.71.62] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 22 On Thu, Jun 04, 2015 at 11:04:36AM -0700, Doug Anderson wrote: > The dw_hdmi_connector_get_modes() function accidentally forgets to > return the number of modes it added, although it has this information > stored in a local variable. Let's fix that. > > Without this fix, drm_helper_probe_single_connector_modes_merge_bits() > could get confused and always call drm_add_modes_noedid(). That's not > right. > > Signed-off-by: Doug Anderson > --- > drivers/gpu/drm/bridge/dw_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/