Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546AbbFELmQ (ORCPT ); Fri, 5 Jun 2015 07:42:16 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:36682 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbbFELmN convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 07:42:13 -0400 MIME-Version: 1.0 In-Reply-To: <20150605112050.GA17776@ulmo.nvidia.com> References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> <20150605112050.GA17776@ulmo.nvidia.com> Date: Fri, 5 Jun 2015 13:42:13 +0200 X-Google-Sender-Auth: Kh2ZlhGFhbMb2VzBfDZu0su1sKc Message-ID: Subject: Re: [PATCH 01/27] drm/bridge: ptn3460: #include , depend on GPIOLIB From: Geert Uytterhoeven To: Thierry Reding Cc: Linus Walleij , Alexandre Courbot , Arnd Bergmann , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , DRI Development Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2338 Lines: 50 Hi Thierry, On Fri, Jun 5, 2015 at 1:20 PM, Thierry Reding wrote: > On Tue, May 05, 2015 at 06:32:17PM +0200, Geert Uytterhoeven wrote: >> If GPIOLIB=n and asm-generic/gpio.h is not used: >> >> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’: >> drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’ >> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’: >> drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’ >> drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast >> drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’ >> drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast >> >> Add the missing #include to fix this. >> >> As the resulting driver won't work with GPIOLIB=n anyway, make >> DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST. >> >> Signed-off-by: Geert Uytterhoeven >> Cc: David Airlie >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/bridge/Kconfig | 4 ++-- >> drivers/gpu/drm/bridge/ptn3460.c | 1 + >> 2 files changed, 3 insertions(+), 2 deletions(-) > > Applied, thanks. Note that I dropped the part about adding the GPIOLIB > dependency because that had been attempted previously to fix this, but > it causes recursive dependencies on PowerPC (ppc64_defconfig). I don't > know of a way to untangle those (I tried and failed miserably), so I > think adding the include is really as good as it'll get. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/