Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbbFENwg (ORCPT ); Fri, 5 Jun 2015 09:52:36 -0400 Received: from mail.skyhub.de ([78.46.96.112]:37831 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbbFENwc (ORCPT ); Fri, 5 Jun 2015 09:52:32 -0400 Date: Fri, 5 Jun 2015 15:52:30 +0200 From: Borislav Petkov To: Wan ZongShun Cc: Wan ZongShun , Ulf Hansson , "linux-mmc@vger.kernel.org" , linux-kernel , Wan ZongShun Subject: Re: [PATCH] SDHCI: Change AMD SDHCI quirk application scope Message-ID: <20150605135230.GJ3679@pd.tnic> References: <1433428437-6067-1-git-send-email-Vincent.Wan@amd.com> <20150604153220.GA4521@pd.tnic> <20150605092001.GB3679@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 36 On Fri, Jun 05, 2015 at 06:01:56PM +0800, Wan ZongShun wrote: > The KERNCZ is new AMD SB/FCH generation name, like HUDSON2 is old FCH > generation. > We will adopt 0x790b as device ID since from this KERNCZ gereration. True story. Strange name that. > The i2cpiix4.c driver and eMMC driver both will use this device ID > macro, Do you think I should submit two patches synchronously? like > patch1: change i2cpiix4 driver to use PCI_DEVICE_ID_AMD_KERNCZ_SMBUS, > patch2: for eMMC quirk in sdhci-pci.c? > > And then the PCI_DEVICE_ID_AMD_KERNCZ_SMBUS can be go into pci ids.h? If you have all those patches ready, you could do a first patch adding the PCI ID to pci_ids.h only. Then follow with the different driver changes, i.e. sdhci-pci.c, i2cpiix4, and so on and make it clear in the 0/n message that they all depend on the first one. Or something along those lines. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/