Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423557AbbFEOWN (ORCPT ); Fri, 5 Jun 2015 10:22:13 -0400 Received: from foss.arm.com ([217.140.101.70]:44419 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbbFEOWL (ORCPT ); Fri, 5 Jun 2015 10:22:11 -0400 Date: Fri, 5 Jun 2015 15:22:06 +0100 From: Will Deacon To: Joerg Roedel Cc: "iommu@lists.linux-foundation.org" , Kukjin Kim , David Woodhouse , Heiko Stuebner , Hiroshi Doyu , Thierry Reding , Alex Williamson , Robin Murphy , Laurent Pinchart , Oded Gabbay , "jroedel@suse.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 00/22 v2] Introduce default domains for iommu groups Message-ID: <20150605142206.GB7420@arm.com> References: <1432831305-11126-1-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432831305-11126-1-git-send-email-joro@8bytes.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1630 Lines: 37 Hi Joerg, On Thu, May 28, 2015 at 05:41:23PM +0100, Joerg Roedel wrote: > here is the second version of my patch-set to introduce > default domains into the iommu core. This time it has a lot > more patches, mostly because I added a proof of concept > implementation by converting the AMD IOMMU driver to make > use of it. Most of this looks fine to me, modulo by comments about the dm regions (which I'm not sure how to implement for ARM). > Converting the first driver to the new concept triggered a > lot of changes and extensions in the patch-set to fit all > the needs of a more complex iommu driver. Converting other > drivers might need further changes, but that is something > for the future. > > A major change is that now the default domain has to be > allocated by the code that allocates the iommu group. For > PCI devices this happens in the IOMMU core, but drivers > allocating the group on their own can now implement a policy > that fits their needs (e.g. not allocate one domain per > group but let multiple groups share one domain). Makes sense. I really think we should be moving group allocation out of the IOMMU drivers and into the bus code, like we already have for PCI. Once we've got a way to describe groups of platform devices (e.g. in the device-tree), then we can have the group creation happen automatically as part of Laurent's of_iommu work. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/