Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424066AbbFEOqa (ORCPT ); Fri, 5 Jun 2015 10:46:30 -0400 Received: from mail1.windriver.com ([147.11.146.13]:43039 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424049AbbFEOqY (ORCPT ); Fri, 5 Jun 2015 10:46:24 -0400 Message-ID: <5571B63A.8040507@windriver.com> Date: Fri, 5 Jun 2015 10:46:18 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Chris Metcalf , Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure References: <1433514964-5945-1-git-send-email-paul.gortmaker@windriver.com> <5571B55E.3040704@ezchip.com> In-Reply-To: <5571B55E.3040704@ezchip.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1616 Lines: 37 On 15-06-05 10:42 AM, Chris Metcalf wrote: > On 06/05/2015 10:36 AM, Paul Gortmaker wrote: >> Pending header cleanups will reveal this file is using the >> init.h content implicitly with the following fail: >> >> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default] >> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall' >> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default] >> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used >> >> Explicitly add init.h to get arch_initcall and avoid this. >> >> Reported-by: kbuild test robot >> Cc: Chris Metcalf >> Signed-off-by: Paul Gortmaker >> --- >> >> [adding this to the header move series of commits; see >> https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com >> for original series posting. ] >> >> arch/tile/kernel/usb.c | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Chris Metcalf > > or I'm happy to take it into the tile tree if you'd rather I did. Thanks, I'll carry it since I'd risk introducing bisection failures if my header changes go in without this being present 1st. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/