Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833AbbFEPZr (ORCPT ); Fri, 5 Jun 2015 11:25:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43922 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbbFEPZn (ORCPT ); Fri, 5 Jun 2015 11:25:43 -0400 Date: Fri, 5 Jun 2015 16:25:37 +0100 From: Mark Brown To: Richard Fitzgerald Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20150605152537.GU14071@sirena.org.uk> References: <1433514886-11884-1-git-send-email-rf@opensource.wolfsonmicro.com> <1433514886-11884-3-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lhOtAiCshckiypUO" Content-Disposition: inline In-Reply-To: <1433514886-11884-3-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regmap: Fix permissions on debugfs cache controls X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 46 --lhOtAiCshckiypUO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2015 at 03:34:46PM +0100, Richard Fitzgerald wrote: > The cache_only and cache_bypass debugfs entries are expected > to be writable by user-side but are set to read-only permissions. Your expectation is not my expectation here :) The permissions here are quite deliberate. > This is only working accidentally because debugfs doesn't currently > honour the read-only bit. Honestly it wasn't supposed to be working at all. We can have a discussion about if it makes sense for it to work, that's not a totally unreasonable thing though I'd really want to taint the kernel if anyone actually does it (particularly for cache only) since it seems even more likely to interact poorly with drivers than random register writes. We'll also want to sync the cache when transitioning from cache only to normal operation I think, or provide a way of doing that. --lhOtAiCshckiypUO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcb9wAAoJECTWi3JdVIfQbTwH/iji8qlMeNho8Qp2JfIcr5ag Xbaxel3JPpznLSXx5ggEeqoSM/fiGuSoy2ePJyLmJ33CAcsL+F/PKaJJ4VBzCysU +ObrVbKMYoR7fMmzXSja/kIQHKGtYtgPLE1YF+/+uyyeiYniKbWvXGNUMIDap83X wPspVNTM+Upa2miFGTT44wtKjcrz2CB4xbIUYzz4KHJS1wKQjRvwEjGITkR9lQ7A HyCy+gb+BXD7+H2ToEe1vmiSslO1c60ZZaNijs2rmZyqvvF2p9J3GnXiiE7UmQ1X +Z9mWIax5Wq5hvS+VxfWOUYc7E4fEwb/hZGFSQF9HpNqjhCwC/9xx2Z4HoHNFtM= =G789 -----END PGP SIGNATURE----- --lhOtAiCshckiypUO-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/