Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755275AbbFEQRf (ORCPT ); Fri, 5 Jun 2015 12:17:35 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:51214 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbbFEQRa (ORCPT ); Fri, 5 Jun 2015 12:17:30 -0400 Message-ID: <5571CB8D.7030401@ti.com> Date: Fri, 5 Jun 2015 19:17:17 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: , Tony Lindgren , , , CC: , , , , Subject: Re: [PATCH 0/3] dmaengine: ti-dma-crossbar: Support for eDMA References: <1433518474-26628-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1433518474-26628-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 49 On 06/05/2015 06:34 PM, Peter Ujfalusi wrote: > Hi, > > The ti-dma-crossbar driver in it's current form can work when it is used with > sDMA (omap-dma). On DRA7x class of devices we have both sDMA and eDMA available. > The DT bindings for sDMA has been done in a way that DMA users need to specify > the required DMA request number + 1 when they request for channel and the driver > stack has been written in this way also for sDMA. > Since right now we do not have the crossbar enabled we can still change the > compatible string to reflect the crossbar use. The TRM also refers the crossbars > in this way. Now that I have sent this series... Would it be better to not touch the compatible strings, but add of_device_id table in the ti-dma-crossbar driver containing the supported dma controllers, like "ti,omap4430-sdma" and "ti,edma3" and to of_match_node() against the node we got via dma-masters? So we would keep the ti,dra7-dma-crossbar and depending on where the dma-masters point us we can decide in the code on how to handle? Just a thought. > > Regards, > Peter > --- > Misael Lopez Cruz (2): > dmaengine: ti-dma-crossbar: Make idr xbar instance-specific > dmaengine: ti-dma-crossbar: Add support for eDMA xbar > > Peter Ujfalusi (1): > dmaengine: ti-dma-crossbar: Change the compatible string to > ti,dra7-sdma-crossbar > > Documentation/devicetree/bindings/dma/dma.txt | 2 +- > .../devicetree/bindings/dma/ti-dma-crossbar.txt | 5 +-- > drivers/dma/ti-dma-crossbar.c | 37 ++++++++++++++++------ > 3 files changed, 31 insertions(+), 13 deletions(-) > -- P?ter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/