Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423039AbbFEQnG (ORCPT ); Fri, 5 Jun 2015 12:43:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43984 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423021AbbFEQnA (ORCPT ); Fri, 5 Jun 2015 12:43:00 -0400 Date: Fri, 5 Jun 2015 17:42:55 +0100 From: Mark Brown To: Richard Fitzgerald Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20150605164255.GV14071@sirena.org.uk> References: <1433514886-11884-1-git-send-email-rf@opensource.wolfsonmicro.com> <1433514886-11884-2-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cCEKa9UdY3MtHM1R" Content-Disposition: inline In-Reply-To: <1433514886-11884-2-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] debugfs: support read-only and write-only bool types X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 40 --cCEKa9UdY3MtHM1R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote: > +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf, > + size_t count, loff_t *ppos) > +{ > + return -EACCES; > +} Perhaps I'm missing something but shouldn't we be able to just omit empty functions like this (this seems to be what the other ro/wo debugfs defintions do otherwise these would already be there and it's what I'd expect)? --cCEKa9UdY3MtHM1R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcdGOAAoJECTWi3JdVIfQnmoH/2QrN8l9n0fmy5HDTPyMH7cV rJaj9IPCjbiV8KaAOE/uQDg6gvuMVqvAjwNEHSj7Vkw6vqlSXPQeF2FyYF2XSRDD IqtIyg+khh8gqV8eKN/MkIhTJG+qwALxhNKVTPuJmNpvGWp4q0p5pLXBIzPShZtE dgrP119u1z0ibLgFVdo5cjxuMaJK5XE8yc1r0/D21NvgMWBiYyB9jUFT3vAupKbd v4lS+Hm6geiwQ6BNi9g1RqKnBlCUINWnutfz0MqKE92Yu97B3CiThBHdQ7meSXYD Q0Kf/D9TW0M1rAeV0kXp6ClELXcKFjgw/kb8K+avUEPCEKEmNfbfFy/uDiDVHxY= =cGSZ -----END PGP SIGNATURE----- --cCEKa9UdY3MtHM1R-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/