Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422838AbbFERha (ORCPT ); Fri, 5 Jun 2015 13:37:30 -0400 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:37148 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932891AbbFERa7 (ORCPT ); Fri, 5 Jun 2015 13:30:59 -0400 X-Sender-Id: abbotti@mev.co.uk From: Ian Abbott To: Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , Subject: [PATCH 10/32] staging: comedi: das08: rename and rewrite DAS08_EOC Date: Fri, 5 Jun 2015 18:30:13 +0100 Message-Id: <1433525435-12986-11-git-send-email-abbotti@mev.co.uk> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1433525435-12986-1-git-send-email-abbotti@mev.co.uk> References: <1433525435-12986-1-git-send-email-abbotti@mev.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 41 The `DAS08_EOC` macro contains a mask for the "end of A/D conversion" bit in the status register. The logic is reverse sense in that the bit is set to 1 while the conversion is in progress and set to 0 when the conversion is complete. Rename the macro to `DAS08_STATUS_AI_BUSY` and add a comment. Also make use of the `BIT()` macro to define the value. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das08.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c index eecbf4d..0484308 100644 --- a/drivers/staging/comedi/drivers/das08.c +++ b/drivers/staging/comedi/drivers/das08.c @@ -58,7 +58,7 @@ #define DAS08_AI_MSB_REG 0x01 /* (R) AI most significant bits */ #define DAS08_AI_TRIG_REG 0x01 /* (W) AI software trigger */ #define DAS08_STATUS_REG 0x02 /* (R) status */ -#define DAS08_EOC (1<<7) +#define DAS08_STATUS_AI_BUSY BIT(7) /* AI conversion in progress */ #define DAS08_IRQ (1<<3) #define DAS08_IP(x) (((x)>>4)&0x7) #define DAS08_CONTROL 2 @@ -206,7 +206,7 @@ static int das08_ai_eoc(struct comedi_device *dev, unsigned int status; status = inb(dev->iobase + DAS08_STATUS_REG); - if ((status & DAS08_EOC) == 0) + if ((status & DAS08_STATUS_AI_BUSY) == 0) return 0; return -EBUSY; } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/