Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbbFETXS (ORCPT ); Fri, 5 Jun 2015 15:23:18 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:50995 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbbFETXR (ORCPT ); Fri, 5 Jun 2015 15:23:17 -0400 Date: Fri, 5 Jun 2015 12:23:13 -0700 From: Guenter Roeck To: Peter Jones Cc: Matt Fleming , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Tony Luck Subject: Re: [PATCH] efi: Work around ia64 build problem with ESRT driver. Message-ID: <20150605192313.GA20232@roeck-us.net> References: <20150605191329.GA23480@redhat.com> <1433531694-24439-1-git-send-email-pjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433531694-24439-1-git-send-email-pjones@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2215 Lines: 53 On Fri, Jun 05, 2015 at 03:14:54PM -0400, Peter Jones wrote: > So, I'm told this problem exists in the world: > ---------------------------------------------- > Subject: Build error in -next due to 'efi: Add esrt support' > > Building ia64:defconfig ... failed > -------------- > Error log: > > drivers/firmware/efi/esrt.c:28:31: fatal error: asm/early_ioremap.h: No > such file or directory > ---------------------------------------------- > > I'm not really sure how it's okay that we have things in asm-generic on > some platforms but not others - is having it the same everywhere not the > whole point of asm-generic? > > That said, ia64 doesn't have early-ioremap.h . So instead, since it's > difficult to imagine new IA64 machines with UEFI 2.5, just don't build > this code there. > > To me this looks like a workaround - doing something like: > > generic-y += early_ioremap.h > > in arch/ia64/include/asm/Kbuild would appear to be more correct, but > ia64 has its own early_memremap() decl in arch/ia64/include/asm/io.h , > and it's a macro. So adding the above /and/ requiring that asm/io.h be > included /after/ asm/early_ioremap.h in all cases would fix it, but > that's pretty ugly as well. Since I'm not going to spend the rest of my > life rectifying ia64 headers vs "generic" headers that aren't generic, > it's much simpler to just not build there. > > Note that I've only actually tried to build this patch on x86_64, but > esrt.o still gets built there, and that would seem to demonstrate that > the conditional building is working correctly at all the places the code > built before. I no longer have any ia64 machines handy to test that the > exclusion actually works there. > > Signed-off-by: Peter Jones > Acked-by: Tony Luck The ia64:defconfig build passes with this patch, so Reviewed-by: Guenter Roeck (Compile-)Tested-by: Guenter Roeck Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/