Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbbFEVhp (ORCPT ); Fri, 5 Jun 2015 17:37:45 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:34795 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbFEVho convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 17:37:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433509230-22238-1-git-send-email-mingo@kernel.org> <20150605133714.GH3679@pd.tnic> From: Andy Lutomirski Date: Fri, 5 Jun 2015 14:37:22 -0700 Message-ID: Subject: Re: [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S To: "H. Peter Anvin" Cc: Borislav Petkov , Ingo Molnar , "linux-kernel@vger.kernel.org" , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1960 Lines: 56 On Fri, Jun 5, 2015 at 2:09 PM, H. Peter Anvin wrote: > Call it sys if it is now only the system call entry points. Agreed with _64_compat too. > > Breaking up these snarls of spaghetti assembly will be a blessing. I'm not too picky about what we call it or whether we merge it with entry_64.S. *However*, I think the file name should end in _64.S. The whole arch/x86 tree is arranged such that files that end in _64.S or _64.c are build for 64-bit kernels and not for 32-bit kernels. I see no reason to deviate from that. FWIW, I'm eventually planning to completely rewrite the compat entry points to use the new (RFC patches coming in a week or two I hope!) C exit code with opportunistic sysretl at the end. I'm guessing the result will be about half the size of the current code, and it'll be comprehensible to mere mortals. --Andy > > On June 5, 2015 6:37:14 AM PDT, Borislav Petkov wrote: >>On Fri, Jun 05, 2015 at 03:00:29PM +0200, Ingo Molnar wrote: >>> I'm wondering what people think about this naming scheme: >>> >>> entry_32.S # 32-bit binaries on 32-bit >>kernels >>> entry_64.S # 64-bit binaries on 64-bit >>kernels >>> entry_64_compat_32.S # 32-bit binaries on 64-bit >>kernels >>> >>> Another option would be: >>> >>> arch/x86/entry/sys_32.S >>> arch/x86/entry/sys_64.S >>> arch/x86/entry/sys_64_compat.S >> >>I like this one better because entry_64_compat_32 kinda has both >>bitness in >>there and confuses me more. >> >>Just my 2 ยข. :) > > -- > Sent from my mobile phone. Please pardon brevity and lack of formatting. -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/