Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbbFEWgS (ORCPT ); Fri, 5 Jun 2015 18:36:18 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:57466 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751722AbbFEWgP (ORCPT ); Fri, 5 Jun 2015 18:36:15 -0400 Message-ID: <5572245E.4080000@ni.com> Date: Fri, 05 Jun 2015 17:36:14 -0500 From: Jaeden Amero User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Sergei Shtylyov , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] net/phy: micrel: Center FLP timing at 16ms References: <1433534130-16323-1-git-send-email-jaeden.amero@ni.com> <1433534130-16323-4-git-send-email-jaeden.amero@ni.com> <55721027.6030509@cogentembedded.com> In-Reply-To: <55721027.6030509@cogentembedded.com> X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/05/2015 05:36:14 PM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/05/2015 05:36:14 PM, Serialize complete at 06/05/2015 05:36:14 PM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-06-06_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 36 On 06/05/2015 04:09 PM, Sergei Shtylyov wrote: >> @@ -441,6 +461,7 @@ static int ksz9031_config_init(struct phy_device >> *phydev) >> "txd2-skew-ps", "txd3-skew-ps" >> }; >> static const char *control_skews[2] = {"txen-skew-ps", >> "rxdv-skew-ps"}; >> + int result; > > You hardly need this variable... > >> >> if (!of_node && dev->parent->of_node) >> of_node = dev->parent->of_node; >> @@ -462,7 +483,10 @@ static int ksz9031_config_init(struct phy_device >> *phydev) >> MII_KSZ9031RN_TX_DATA_PAD_SKEW, 4, >> tx_data_skews, 4); >> } >> - return 0; >> + >> + result = ksz9031_center_flp_timing(phydev); >> + >> + return result; > > Why not just return directly? > Genius. Thanks for the feedback. I'll post a v3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/