Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbbFEWuT (ORCPT ); Fri, 5 Jun 2015 18:50:19 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:38976 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751411AbbFEWuR convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 18:50:17 -0400 Message-ID: <557227A7.2080603@ni.com> Date: Fri, 05 Jun 2015 17:50:15 -0500 From: Jaeden Amero User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] net/phy: micrel: Center FLP timing at 16ms References: <1433544046-17595-1-git-send-email-jaeden.amero@ni.com> <1433544046-17595-4-git-send-email-jaeden.amero@ni.com> <5572261A.1070801@gmail.com> In-Reply-To: <5572261A.1070801@gmail.com> X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/05/2015 05:50:15 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/05/2015 05:50:15 PM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-06-06_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 47 On 06/05/2015 05:43 PM, Florian Fainelli wrote: > On 05/06/15 15:40, Jaeden Amero wrote: >> Link failures have been observed when using the KSZ9031 with HP 1810-8G >> and HP 1910-8G network switches. Center the FLP timing at 16ms to help >> avoid intermittent link failures. >> >> From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section >> "Auto-Negotiation Timing": >> The KSZ9031[RNX or MNX] Fast Link Pulse (FLP) burst-to-burst >> transmit timing for Auto-Negotiation defaults to 8ms. IEEE 802.3 >> Standard specifies this timing to be 16ms +/-8ms. Some PHY link >> partners need to receive the FLP with 16ms centered timing; >> otherwise, there can be intermittent link failures and long >> link-up times. >> >> After KSZ9031[RNX or MNX] power-up/reset, program the following >> register sequence to set the FLP timing to 16ms >> >> Write Register Dh = 0x0000 // Set up register address for MMD – Device Address 0h >> Write Register Eh = 0x0004 // Select Register 4h of MMD – Device Address 0h >> Write Register Dh = 0x4000 // Select register data for MMD – Device Address 0h, Register 4h >> Write Register Eh = 0x0006 // Write value 0x0006 to MMD – Device Address 0h, Register 4h >> Write Register Dh = 0x0000 // Set up register address for MMD – Device Address 0h >> Write Register Eh = 0x0003 // Select Register 3h of MMD – Device Address 0h >> Write Register Dh = 0x4000 // Select register data for MMD – Device Address 0h, Register 3h >> Write Register Eh = 0x1A80 // Write value 0x1A80 to MMD – Device Address 0h, Register 3h >> Write Register 0h, Bit [9] = 1 // Restart Auto-Negotiation > > Quoting a portion of the data-sheet on how to do this programming is > very strange considering that the code is going to be the reference, not > the commit message. I included it for lack of something better to quote that explained which values to set when. I'd be happy to revise the message as this appears too strange. > Other than that, this looks reasonable. Thanks very much for the review. Cheers, Jaeden -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/