Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbbFFHvD (ORCPT ); Sat, 6 Jun 2015 03:51:03 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54710 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbbFFHuy (ORCPT ); Sat, 6 Jun 2015 03:50:54 -0400 Date: Sat, 6 Jun 2015 09:50:50 +0200 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, kbuild-all@01.org Subject: Re: [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors Message-ID: <20150606075050.GA545@pd.tnic> References: <1433545654-24450-1-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1433545654-24450-1-git-send-email-Aravind.Gopalakrishnan@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 45 On Fri, Jun 05, 2015 at 06:07:34PM -0500, Aravind Gopalakrishnan wrote: > Even though !CONFIG_SMP and MCE injection are practically mutually > exclusive, it's better to include irq_vectors.h just in case > randconfig builders out there don't set CONFIG_SMP. > > When that happens, DEFERRED_ERROR_VECTOR and THRESHOLD_APIC_VECTOR > macro definitions go out of scope and kernel build will fail. Good! > Tested the .config that broke the build against latest tip with > changes in for-next branch of bp.git and it builds fine now. > > Reported-by: kbuild test robot > Cc: kbuild-all@01.org > Signed-off-by: Aravind Gopalakrishnan > --- > drivers/edac/mce_amd_inj.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c > index 3f7217f..3e1b53f 100644 > --- a/drivers/edac/mce_amd_inj.c > +++ b/drivers/edac/mce_amd_inj.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #include "mce_amd.h" Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/