Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbbFFJCM (ORCPT ); Sat, 6 Jun 2015 05:02:12 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34322 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbbFFJCG (ORCPT ); Sat, 6 Jun 2015 05:02:06 -0400 Date: Sat, 6 Jun 2015 14:32:51 +0530 From: Aparna Karuthodi To: gregkh@linuxfoundation.org Cc: markh@compro.net, lidza.louina@gmail.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@vger.kernel.org, Message-ID: <20150606090251.GB8087@gmail.com> References: <20150606085628.GA8087@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="UHN/qo2QbUvPLonB" Content-Disposition: inline In-Reply-To: <20150606085628.GA8087@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3302 Lines: 109 --UHN/qo2QbUvPLonB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote: > From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001 > From: Aparna Karuthodi > Date: Sat, 6 Jun 2015 11:01:16 +0530 > Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary > for single statement blocks > > Removed the braces of if else statements which contain only one > statement > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > index f81a375..6cd0b6a 100644 > --- a/drivers/staging/dgnc/dgnc_tty.c > +++ b/drivers/staging/dgnc/dgnc_tty.c > @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) > * 3) NONE - Do nothing. Since we didn't do anything to turn off the > * other side, we don't need to do anything now. > */ > - if (qleft > (RQUEUESIZE / 2)) { > + if (qleft > (RQUEUESIZE / 2)) > /* HWFLOW */ > if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) { > if (ch->ch_flags & CH_RECEIVER_OFF) { > @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) > ch->ch_bd->bd_ops->send_start_character(ch); > } > /* No FLOW */ > - else { > + else > /* Nothing needed. */ > - } > - } > + > + > } > > > -- > 1.7.9.5 > --UHN/qo2QbUvPLonB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0003-PATCH-staging-dgnc-Fixed-braces-are-not-necessary-fo.patch" >From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001 From: Aparna Karuthodi Date: Sat, 6 Jun 2015 11:01:16 +0530 Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks Removed the braces of if else statements which contain only one statement Signed-off-by: Aparna Karuthodi --- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index f81a375..6cd0b6a 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) * 3) NONE - Do nothing. Since we didn't do anything to turn off the * other side, we don't need to do anything now. */ - if (qleft > (RQUEUESIZE / 2)) { + if (qleft > (RQUEUESIZE / 2)) /* HWFLOW */ if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) { if (ch->ch_flags & CH_RECEIVER_OFF) { @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) ch->ch_bd->bd_ops->send_start_character(ch); } /* No FLOW */ - else { + else /* Nothing needed. */ - } - } + + } -- 1.7.9.5 --UHN/qo2QbUvPLonB-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/