Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbbFFMAL (ORCPT ); Sat, 6 Jun 2015 08:00:11 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47283 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752451AbbFFMAE (ORCPT ); Sat, 6 Jun 2015 08:00:04 -0400 Date: Sat, 6 Jun 2015 13:58:33 +0200 From: Maxime Ripard To: Sanchayan Maity Cc: arnd@arndb.de, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, stefan@agner.ch, kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Message-ID: <20150606115833.GP23777@lukather> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Iuot8e5drzPqTM+3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2390 Lines: 71 --Iuot8e5drzPqTM+3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote: > Add a device tree node for the On-Chip One Time Programmable > Controller (OCOTP) and the On-Chip ROM. >=20 > Signed-off-by: Sanchayan Maity > --- > arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 2f4b04d..ed9b6b8 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -56,6 +56,13 @@ > compatible =3D "simple-bus"; > interrupt-parent =3D <&mscm_ir>; > ranges; > + ocotp-cfg =3D <&ocotp 0x410 0x420>; > + rom-revision =3D <&ocrom 0x80>; > + > + ocrom: ocrom { > + compatible =3D "fsl,vf610-ocrom", "syscon"; > + reg =3D <0x00000000 0x18000>; > + }; Shouldn't that use the new nvmem framework currently being discussed, instead of defining custom bindings? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --Iuot8e5drzPqTM+3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVcuBpAAoJEBx+YmzsjxAgIX4QALmzL8VtkAPXat7qUv9BXGPg aFBp5/itVZzY6U1qhxpD9KdW4CMeFb5hYV9zZflRlvjS5+Lies94gJti965TAzJ5 KG2BHaexGklkzVBfqRJsq1gm6jaCseat9dBOIvPgMuXjmG8PifSczW8Rn2lpDXUs d7Y4ITnGgsMacX587CX3+Vlop4Xf2cmD4HcQ+QuVkPzmO8RXAKnW35lmPcO003PP y7H18st+fp67m7S8zCIWLvheIWKEo/DTj5v2YKLcop8n3wlTtA0/KWjATrm2m72m Nkb0jhuRfBw9PFcAIKZ/QFxxZbitukEVpsMKqEnwwZvtxdJ3bX843AufNkY3Ajh4 DA2v/4WYLtMIj3uvZUAM9M3UBncV6MebMJn6W4urN07gvzTjsSKs5c+85aRN/mKN A+ubtNleCWTW2Y9yTwJfjeXOA1DM2m5lEuKgcrA7Ok6/csIOaBBd3mRuoBoBnBha MA9dD5o8m2ELpNbnoa6zOvE+J/ooY4up5735bIfOAjra0FZ2LusKBGWK9kBQ0Eh3 n5HUdd9YVWP55I4k+5xwChIJbpJQRBvsHLf5BxqD4lbMEODsPSKK9H4w/PyfXqxw piYFPdCgEc0X51Y4eARA+KpAaiVqq59Nle9YBcgxih6UUAzCZv0NqF1+u01QG+nG 55VxD4Rcn6i1/iKdTv/9 =6Yxe -----END PGP SIGNATURE----- --Iuot8e5drzPqTM+3-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/