Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109AbbFFM12 (ORCPT ); Sat, 6 Jun 2015 08:27:28 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:55081 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbbFFM1U (ORCPT ); Sat, 6 Jun 2015 08:27:20 -0400 Message-ID: <1433593634.10861.65.camel@x220> Subject: Re: [RFC PATCH 1/3] STM trace event: Adding generic buffer interface driver From: Paul Bolle To: Chunyan Zhang Cc: Steven Rostedt , mingo@redhat.com, Mathieu Poirier , Kaixu Xia , Serge Broslavsky , Mark Brown , alexander.shishkin@linux.intel.com, "linux-kernel@vger.kernel.org" Date: Sat, 06 Jun 2015 14:27:14 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 51 On Fri, 2015-06-05 at 13:37 +0800, Chunyan Zhang wrote: > --- a/drivers/stm/Kconfig > +++ b/drivers/stm/Kconfig > +config STM_TRACE_EVENT > + tristate "Redirect/copy the output from kernel trace event to > STM engine" > + depends on STM > + help > + This option can be used to redirect or copy the output from > kernel trace > + event to STM engine. Enabling this option will introduce a slight > + timing effect. > + > + If you want to send kernel trace event messages over STM devices, > + say Y. It seems your mailer (or some mailserver) mangled this part. > --- /dev/null > +++ b/drivers/stm/stm_trace_event.c > +static int stm_trace_event_init(void) > +{ > + return stm_source_register_device(NULL, &stm_trace_event_data); > +} Is there are reason not to mark this __init? > +static void stm_trace_event_exit(void) > +{ > + stm_source_unregister_device(&stm_trace_event_data); > +} Ditto, but here it's __exit, of course. > +module_init(stm_trace_event_init); > +module_exit(stm_trace_event_exit); (These are not rhetorical questions. I actually wonder whether there a reasons not to mark module_init() and module_exit() functions with __init and __exit.) Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/