Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbbFFM5t (ORCPT ); Sat, 6 Jun 2015 08:57:49 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:44153 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbbFFM5l (ORCPT ); Sat, 6 Jun 2015 08:57:41 -0400 Message-ID: <1433595457.10861.77.camel@x220> Subject: Re: [PATCH v2 4/4] VFIO: platform: Calxeda xgmac reset module From: Paul Bolle To: Eric Auger Cc: eric.auger@st.com, linux-arm-kernel@lists.infradead.org, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org, agraf@suse.de Date: Sat, 06 Jun 2015 14:57:37 +0200 In-Reply-To: <1433516792-16397-5-git-send-email-eric.auger@linaro.org> References: <1433516792-16397-1-git-send-email-eric.auger@linaro.org> <1433516792-16397-5-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 27 On Fri, 2015-06-05 at 17:06 +0200, Eric Auger wrote: > --- /dev/null > +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c > +static int __init vfio_platform_calxedaxgmac_init(void) > +{ > + return 0; > +} > + > +static void __exit vfio_platform_calxedaxgmac_exit(void) > +{ > +} > + > +module_init(vfio_platform_calxedaxgmac_init); > +module_exit(vfio_platform_calxedaxgmac_exit); Just a nit: I think it's OK to leave out these functions if they both do nothing. See delete_module in kernel/module.c. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/