Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932468AbbFFNbM (ORCPT <rfc822;w@1wt.eu>);
	Sat, 6 Jun 2015 09:31:12 -0400
Received: from mail.kmu-office.ch ([178.209.48.109]:55990 "EHLO
	mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752954AbbFFNbI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 6 Jun 2015 09:31:08 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Date: Sat, 06 Jun 2015 15:29:02 +0200
From: Stefan Agner <stefan@agner.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Mark Salter <msalter@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Kees Cook <keescook@chromium.org>,
        Laura Abbott <lauraa@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3] ARM: early fixmap support for earlycon
In-Reply-To: <20150606124800.GR7557@n2100.arm.linux.org.uk>
References: <1433593888-7142-1-git-send-email-stefan@agner.ch>
 <20150606124800.GR7557@n2100.arm.linux.org.uk>
Message-ID: <25ac891cd5876d4141e03317bf0d4173@agner.ch>
User-Agent: Roundcube Webmail/1.1.1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2322
Lines: 61

On 2015-06-06 14:48, Russell King - ARM Linux wrote:
> On Sat, Jun 06, 2015 at 02:31:28PM +0200, Stefan Agner wrote:
<snip>
>> --- a/arch/arm/include/asm/fixmap.h
>> +++ b/arch/arm/include/asm/fixmap.h
>> @@ -6,9 +6,13 @@
>>  #define FIXADDR_TOP		(FIXADDR_END - PAGE_SIZE)
>>
>>  #include <asm/kmap_types.h>
>> +#include <asm/pgtable.h>
>>
>>  enum fixed_addresses {
>> -	FIX_KMAP_BEGIN,
>> +	FIX_EARLYCON_MEM_BASE,
>> +	__end_of_permanent_fixed_addresses,
>> +
>> +	FIX_KMAP_BEGIN = __end_of_permanent_fixed_addresses,
>>  	FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_TYPE_NR * NR_CPUS) - 1,
>>
>>  	/* Support writing RO kernel text via kprobes, jump labels, etc. */
>> @@ -18,7 +22,14 @@ enum fixed_addresses {
>>  	__end_of_fixed_addresses
>>  };
>>
>> +#define FIXMAP_PAGE_COMMON	(L_PTE_YOUNG | L_PTE_PRESENT | L_PTE_XN | L_PTE_DIRTY)
>> +
>> +#define FIXMAP_PAGE_NORMAL	(FIXMAP_PAGE_COMMON | L_PTE_MT_WRITEBACK)
>> +#define FIXMAP_PAGE_IO		(FIXMAP_PAGE_COMMON | L_PTE_MT_DEV_SHARED | L_PTE_SHARED)
>> +#define FIXMAP_PAGE_NOCACHE	FIXMAP_PAGE_IO
> 
> I'm really not happy with this.  What are the expected semantics of the
> set_fixmap_nocache() and set_fixmap_offset_nocache() ?  Are they there
> for mapping a device, or are they there for mapping _memory_ ?
> 
> I would prefer that FIXMAP_PAGE_NOCACHE is _not_ provided until the
> semantics of that can be clarified, as there is a difference between the
> two on ARM.

set_fixmap_nocache is used for PCIe and IO APIC stuff, so actually IO
devices. However, as far as I understand the x86 page table definitions
in pgtable_types.h, IO devices are not explicitly uncached on x86. The
define set_fixmap_nocache make sure IO devices are mapped uncached...
Maybe set_fixmap_io_nocache instead of set_fixmap_nocache would be more
appropriate...? 

Maybe the initial authors of the common fixmap.h have a more clear
understanding of the expected semantics, Mark?

Since the focus currently is on set_fixmap_io, we could define
FIXMAP_PAGE_IO only for the time being...?

Agreed to the rest, will apply the review in v4.

--
Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/