Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbbFFQTL (ORCPT ); Sat, 6 Jun 2015 12:19:11 -0400 Received: from vpnchicago.adeneo-embedded.us ([65.182.180.190]:17970 "EHLO mxadeneo.adeneo-embedded.us" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752507AbbFFQTH (ORCPT ); Sat, 6 Jun 2015 12:19:07 -0400 Date: Sat, 6 Jun 2015 09:19:03 -0700 From: Jean-Baptiste Theou To: Paul Bolle CC: Valentin Rothberg , Wim Van Sebroeck , Guenter Roeck , , Subject: Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration Message-ID: <20150606091903.944aa609c53ea713952d73f5@adeneo-embedded.us> In-Reply-To: <1433599878.10861.82.camel@x220> References: <1433576786-14947-1-git-send-email-jtheou@adeneo-embedded.us> <1433576786-14947-2-git-send-email-jtheou@adeneo-embedded.us> <1433584986.10861.46.camel@x220> <20150606125611.GA16930@nebuchadnezzar> <1433599878.10861.82.camel@x220> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [67.170.78.158] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 41 Thanks for the feedback. I tested a version before cleanup, and the mistake was introduce during it. It's my mistake, sorry about that. Will fix it on v4. On Sat, 6 Jun 2015 16:11:18 +0200 Paul Bolle wrote: > On Sat, 2015-06-06 at 14:56 +0200, Valentin Rothberg wrote: > > On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote: > > > On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote: > > > > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL > > > > > > You meant > > > #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL > > > > > > Please use scripts/checkkconfigsymbols.py. > > > > checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this > > prefix is missing here, the script would not complain. > > Of course. Thanks for correcting me. > > > But that's an interesting case and worth checking for. > > Perhaps. Depends on the amount of false positives that such checks would > trigger, I'd say. > > > Paul Bolle > -- Jean-Baptiste Theou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/