Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbbFGGTV (ORCPT ); Sun, 7 Jun 2015 02:19:21 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:35183 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbbFGGTO (ORCPT ); Sun, 7 Jun 2015 02:19:14 -0400 MIME-Version: 1.0 In-Reply-To: <87zj4fte9r.fsf@rustcorp.com.au> References: <20150531152932.GA16337@rhlx01.hs-esslingen.de> <87r3pwgd0b.fsf@rustcorp.com.au> <87h9qouuny.fsf@rustcorp.com.au> <87zj4fte9r.fsf@rustcorp.com.au> From: Lucas De Marchi Date: Sun, 7 Jun 2015 03:18:53 -0300 Message-ID: Subject: Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing. To: Rusty Russell Cc: Andreas Mohr , Andrew Morton , Bertrand Jacquin , "Marco d'Itri" , linux-modules , lkml , Jon Masters Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1706 Lines: 43 On Thu, Jun 4, 2015 at 5:22 PM, Rusty Russell wrote: > Lucas De Marchi writes: >>> + gzip and xz (but doesn't by default, at least as of version 18!). >> >> This is pretty much misleading. There's no such a default option. It's >> like saying kernel doesn't support feature X, Y or Z by default >> because make defconfig doesn't turn them on. > > Nobody except Linus expects a defconfig to boot. > > I expect ./configure to give me a working tool; these *are* defaults, > and setting them *is* your responsibility as author. When it became an > in-kernel option rather than some weird distro thing, the old default > was wrong. > > ... Though I hadn't realized that Marco had deliberately decided to > leave support off. Surprising, since liblzma and libz seem required on > Debian anyway. As you can see, no default to something else will make distros adopt that. I long ago decided not to provide a default for compression because it's clearly not agreed upon. Instead it's everything disabled and the distro chooses what it wants to support. So if you think the configuration for your distro should be something else, convince the maintainer to change it showing why it's important. FYI I'm adding in kmod the ability to query the flags used during build. So now we have: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL This will be present in kmod 21 -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/