Date: Sun, 07 Jun 2015 00:18:00 -0700 (PDT)
Message-Id: <20150607.001800.854104281240414676.davem@davemloft.net>
To: hofrat@osadl.org
Cc: kas@fi.muni.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cosa: use msecs_to_jiffies for conversions
From: David Miller <davem@davemloft.net>
In-Reply-To: <1433577111-7404-1-git-send-email-hofrat@osadl.org>
References: <1433577111-7404-1-git-send-email-hofrat@osadl.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 31

From: Nicholas Mc Guire <hofrat@osadl.org>
Date: Sat,  6 Jun 2015 09:51:51 +0200

> @@ -517,7 +517,7 @@ static int cosa_probe(int base, int irq, int dma)
>  		 */
>  		set_current_state(TASK_INTERRUPTIBLE);
>  		cosa_putstatus(cosa, SR_TX_INT_ENA);
> -		schedule_timeout(30);
> +		schedule_timeout(msecs_to_jiffies(300));
>  		irq = probe_irq_off(irqs);
>  		/* Disable all IRQs from the card */
>  		cosa_putstatus(cosa, 0);

You are making these transformations completely inconsistently.

You're converting it to msecs in some patches and here you are doing
something else.

Please do _all_ of these transformations consistently and in a way
that minimizes the chances of breaking things.

And the only way to do that is to strictly convert these cases to
whatever it works out to when HZ=100 since that is strictly the
environment all of this old code was written in.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/