Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbbFGJAN (ORCPT ); Sun, 7 Jun 2015 05:00:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39880 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbbFGJAH (ORCPT ); Sun, 7 Jun 2015 05:00:07 -0400 Date: Sun, 07 Jun 2015 02:00:05 -0700 (PDT) Message-Id: <20150607.020005.1921032930953172020.davem@davemloft.net> To: julien.grall@citrix.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, netdev@vger.kernel.org Subject: Re: [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses From: David Miller In-Reply-To: <1433432114-22198-2-git-send-email-julien.grall@citrix.com> References: <1433432114-22198-1-git-send-email-julien.grall@citrix.com> <1433432114-22198-2-git-send-email-julien.grall@citrix.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 07 Jun 2015 02:00:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 25 From: Julien Grall Date: Thu, 4 Jun 2015 16:35:13 +0100 > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. > > Also use %d rather than %x for rx->offset. > > Signed-off-by: Julien Grall > Reviewed-by: David Vrabel > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: netdev@vger.kernel.org > > --- > Changes in v3: > - Use %d for the rx-offset too. This change in v3 is wrong, 'rx->offset' is unsigned therefore %u is the correct format string to use. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/